-
Notifications
You must be signed in to change notification settings - Fork 976
Escape path in Proguard in order to build xsbt under windows (with spaces in path) #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…efactor InstallExtarctProject in order to be a subclass of the Proguard trait
|
Hi Steve, Thanks for working on this. Comments:
Thanks, |
…re file permission to 644
|
Mark, I've made the appropriate changes, as requested.
Thanks for reading my code, |
|
Thanks, Steve. It looks good now. I assume you replaced @ with -include because @ didn't mix well with escaping? -Mark |
|
My first guess was that @ didn't work with quoted path, but actually no, "@" and "-include " are equivalent. Steve |
|
Hi Steve, Sorry it took so long to get back to you. Using -include is not a problem. Can you squash the commits into one, though? Thanks, |
…efactor InstallExtarctProject in order to be a subclass of the Proguard trait Removed path escaping on classpath... Remove unuseful log.error, change space indent with tab indent, restore file permission to 644
|
Hi Mark, Here is the squash commit (3da8e4f) Enjoy, |
|
Done, thanks. |
Conflicts: src/main/scala/sbt/CrossBuilding.scala
…pendencies of a module
-2.8 uses 2.8.2
Hi Mark,
I've found a problem when trying to build the master branch of xsbt on Windows (especially because I use paths with spaces).
There was some paths used by proguard in InstallExtractProject that was not properly escaped.
When trying to fixed this, I've found that they was a trait ProguardProject where all the proguard stuffs was defined. I've refactored InstallExtractProject to mix this trait, I've not see any problem with that, can you confirm that this fix is correct ?
Thanks,
Steve Gury