Adding scalaOrg setting key for scala clones.#418
Merged
Conversation
Adding scalaOrg key that specifies organization (artifactId) of scala used in the project. The change does not affect version checks for dependecies and LauncherConfiguration. Modified scalaProvider cache in Launcher to use (scalaOrg, version) as a key. Downloaded jars are stored in the folder scala-.../lig-<scalaOrg> if scalaOrg is not default. scala-org is an advanced setting so it can not be used in build.sbt.
Changed the order of parameters in getScala method. Changed the key name to scalaOrganization (scala-organization). Augmented description of the key. Minor fixes.
Added groupId dependant baseDirectoryName. General code cleanup.
Member
|
This is far enough along that it will make it into the beta. Please have these changes made by Thursday and I will review it one last time and merge it for the beta. Thanks! |
Contributor
Author
|
I had to add another |
Member
|
I have verified tests work for the standard Scala organization. To ensure this feature continues to work for you in the future, I suggest writing a scripted test that uses an alternate organization. |
Contributor
Author
|
Thanks for the help. I will put a test in once we get Scala milestones deployed. |
dwijnand
added a commit
to dwijnand/sbt
that referenced
this pull request
Apr 25, 2019
* 1.0.x: (28 commits) Split compiler bridge tests to another subproject Implement compiler bridge for 2.13.0-M2 Add yourkit acknoledgement in the README "sbt '++ 2.13.0-M2!' compile" does not work with sbt 1.0.0 Add header to cached hashing spec Add headers to missing files Fix sbt#332: Add sbt-header back to the build Update sbt-scalafmt to 1.12 Make classpath hashing more lightweight Fix sbt#442: Name hash of value class should include underlying type source-dependencies/value-class-underlying: fix test Ignore null in generic lambda tparams Improve and make scripted parallel Fix sbt#436: Remove annoying log4j scripted exception Fix sbt#127: Use `unexpanded` name instead of `name` Add pending test case for issue/127 source-dependencies / patMat-scope workaround Fixes undercompilation on inheritance on same source Add real reproduction case for sbt/zinc#417 Add trait-trait-212 for Scala 2.12.3 ... Conflicts: internal/zinc-apiinfo/src/main/scala/sbt/internal/inc/ClassToAPI.scala project/build.properties zinc/src/main/scala/sbt/internal/inc/MixedAnalyzingCompiler.scala The ClassToAPI conflict is due to: * sbt/zinc#393 (a 1.x PR), conflicting with * sbt/zinc#446 (a 1.0.x PR). The build.properties conflict is due to different PRs bumping sbt.version from 1.0.0 to 1.0.2 to 1.0.3. (sbt#413, sbt#418, sbt#453). The MixedAnalyzingCompiler conflict is due to: * sbt/zinc#427 (a 1.x PR), conflicting with * sbt/zinc#452 (a 1.0.x PR).
adpi2
pushed a commit
to adpi2/sbt
that referenced
this pull request
Oct 9, 2024
avoid deprecated `java.net.URL` constructor
adpi2
pushed a commit
to adpi2/sbt
that referenced
this pull request
Oct 9, 2024
* Update scala-library to 2.13.10 * Bump semanticdb version too Co-authored-by: Alexandre Archambault <alexandre.archambault@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding scalaOrg key that specifies organization (artifactId) of scala used in the project. The change does not affect version checks for dependecies and LauncherConfiguration.
Modified scalaProvider cache in Launcher to use (scalaOrg, version) as a key.
Downloaded jars are stored in the folder scala-.../lig- if scalaOrg is not default.
scala-org is an advanced setting so it can not be used in build.sbt.