Skip to content

Fixes #2464. Actually reorganize appResolvers#2467

Merged
dwijnand merged 2 commits intosbt:0.13.10from
eed3si9n:wip/jcenter
Feb 21, 2016
Merged

Fixes #2464. Actually reorganize appResolvers#2467
dwijnand merged 2 commits intosbt:0.13.10from
eed3si9n:wip/jcenter

Conversation

@eed3si9n
Copy link
Member

Fixes #2464 and Fixes #2465

appResolvers is a set of resolvers specified in the launcher configuration.
This list fluctuates depending on the version of sbt, and sbt 0.13.10
meant to stabilize it by weeding out JCenter even when it includes it,
which failed when I applied the filter on the wrong list. This should
correct it.

/review @dwijnand

Fixes sbt#2464 and Fixes sbt#2465
appResolvers is a set of resolvers specified in the launcher
configuration.
This list fluctuates depending on the version of sbt, and sbt 0.13.10
meant to stabilize it by weeding out JCenter even when it includes it,
which failed when I applied the filter on the wrong list. This should
correct it.
@dwijnand
Copy link
Member

The change look good.

But could I ask you to add the test I added in #2466 please:
https://github.com/sbt/sbt/pull/2466/files#diff-e6551ff5a8b49c6e2a1152ec8ef6bd87R8

@eed3si9n
Copy link
Member Author

Done

@dwijnand
Copy link
Member

All green, good to go.

dwijnand added a commit that referenced this pull request Feb 21, 2016
Fixes #2464. Actually reorganize appResolvers
@dwijnand dwijnand merged commit 213dc87 into sbt:0.13.10 Feb 21, 2016
@eed3si9n eed3si9n deleted the wip/jcenter branch February 21, 2016 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants