Skip to content

Run unit tests from compileInterface on Travis CI.#2358

Merged
eed3si9n merged 2 commits intosbt:0.13from
gkossakowski:compileInterface-tests
Jan 9, 2016
Merged

Run unit tests from compileInterface on Travis CI.#2358
eed3si9n merged 2 commits intosbt:0.13from
gkossakowski:compileInterface-tests

Conversation

@gkossakowski
Copy link
Contributor

Also, make the intent of the env variable clearer in travis configuration.

Fixes #2357.

Also, make the intent of the env variable clearer in travis configuration.

Fixes sbt#2357.
@typesafe-tools
Copy link

Can one of the admins verify this patch?

@eed3si9n
Copy link
Member

eed3si9n commented Jan 8, 2016

This is actually going to catch a test failure that I mentioned in #2357 (comment) likely coming from 0f61629 in #2343

This is a fixup of 0f61629.
That commit assumed that dealiasing is being done for types referred in
self type. It was changed to not do that but the test wasn't updated.
Unfortunately, that mistake slipped by during PR review because unit tests
of compileInterface were not ran (see sbt#2358).
@dwijnand
Copy link
Member

dwijnand commented Jan 9, 2016

+1

@eed3si9n
Copy link
Member

eed3si9n commented Jan 9, 2016

LGTM

eed3si9n added a commit that referenced this pull request Jan 9, 2016
Run unit tests from compileInterface on Travis CI.
@eed3si9n eed3si9n merged commit 7e88edb into sbt:0.13 Jan 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants