Make sbt aware of Dotty by smarter · Pull Request #2344 · sbt/sbt

smarter · 2015-12-30T23:45:08Z

This small set of changes, together with the compiler-bridge I wrote
(https://github.com/smarter/dotty-bridge) enables us to compile code
using Dotty in sbt, see https://github.com/smarter/dotty-example-project
for an example.

It'd be great if this could go in 0.13.10 as using a custom sbt is very cumbersome, let me know if there's anything I can do to help with that!

lightbend-cla-validator · 2015-12-30T23:45:09Z

Hi @smarter,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:

http://www.typesafe.com/contribute/cla

typesafe-tools · 2015-12-30T23:46:27Z

Can one of the admins verify this patch?

dwijnand · 2015-12-31T00:01:00Z

compile/src/main/scala/sbt/compiler/RawCompiler.scala

This is a breaking (bincompat) change.

OK, will fix, I have no idea what is and isn't public API :). Is it okay if I push-force my branch or do you prefer code reviews to be addressed in separate commits?

Part of 1.0 is making that decision and enforcing it. In these 0.13 days, anything that can be accessed, is public :-/

It's not really been decided, but I'm personally happy with history-rewrites and force pushes.

dwijnand · 2015-12-31T00:02:22Z

This is kind of exciting. I'm surprised it's such a small change.

smarter · 2015-12-31T00:08:15Z

This would have been much harder to get in 0.13 without #2197, so thank you @Duhemm :).

SethTisue · 2015-12-31T00:27:17Z

perhaps instead of the isDotty hack, an actual SettingKey[Boolean] called isDotty?

smarter · 2015-12-31T00:30:43Z

A setting would be slightly annoying if you want your sbt build to support both Scala and Dotty, you'd have to do isDotty := scalaVersion.value.startsWith("0.") yourself, but I'm not opposed to it if people like this better.

smarter · 2015-12-31T00:32:17Z

...Unless the setting default value is scalaVersion.value.startsWith("0.") ? I could do this but I have no idea of the proper place to put this setting in the many dimensions of sbt.

eed3si9n · 2015-12-31T01:34:29Z

Settings generally go into Keys.scala and Defaults.scala. Somewhere around here perhaps? https://github.com/sbt/sbt/blob/v0.13.9/main/src/main/scala/sbt/Defaults.scala#L245

This small set of changes, together with the compiler-bridge I wrote (https://github.com/smarter/dotty-bridge) enables us to compile code using Dotty in sbt, see https://github.com/smarter/dotty-example-project for an example.

smarter · 2016-01-03T19:46:24Z

If I make isDotty a key then we need a way to access isDotty from various classes like RawCompiler, the obvious thing to do would be to add an isDotty field to the class ScalaInstance but this is tricky to do without breaking binary compatibility (I can't change the primary constructor of the class so I'd have to add a mutable field, ...). So I'd rather keep things as-is (no isDotty key) for now and revisit this for 1.0 when we'll break binary compatiblity. Anything else that needs to be done before this can be merged?

eed3si9n · 2016-01-04T00:56:03Z

So I'd rather keep things as-is (no isDotty key) for now and revisit this for 1.0 when we'll break binary compatibility.

That is a very good point.

Anything else that needs to be done before this can be merged?

I think we're good here.

Make sbt aware of Dotty

This small set of changes, together with the compiler-bridge I wrote (https://github.com/smarter/dotty-bridge) enables us to compile code using Dotty in sbt, see https://github.com/smarter/dotty-example-project for an example. Partial forward port of sbt#2344.

eed3si9n added the ready label Dec 30, 2015

dwijnand reviewed Dec 31, 2015
View reviewed changes

smarter force-pushed the 0.13-dotty branch from dd3fa0b to 4b8dc9d Compare December 31, 2015 00:24

Make sbt aware of Dotty

10265ef

This small set of changes, together with the compiler-bridge I wrote (https://github.com/smarter/dotty-bridge) enables us to compile code using Dotty in sbt, see https://github.com/smarter/dotty-example-project for an example.

smarter force-pushed the 0.13-dotty branch from 4b8dc9d to 10265ef Compare January 3, 2016 19:35

eed3si9n added a commit that referenced this pull request Jan 4, 2016

Merge pull request #2344 from smarter/0.13-dotty

f00f6fd

Make sbt aware of Dotty

eed3si9n merged commit f00f6fd into sbt:0.13 Jan 4, 2016

eed3si9n removed the ready label Jan 4, 2016

eed3si9n mentioned this pull request Jan 7, 2016

[sbt 1.0] Forward port 0.13 changes #2352

Closed

7 tasks

This was referenced Jan 17, 2016

FPORT: Make sbt aware of Dotty sbt/zinc#49

Merged

FPORT: Make sbt aware of Dotty sbt/librarymanagement#18

Merged

FPORT: Make sbt aware of Dotty #2393

Merged

Conversation

smarter commented Dec 30, 2015

Uh oh!

lightbend-cla-validator commented Dec 30, 2015

Uh oh!

typesafe-tools commented Dec 30, 2015

Uh oh!

dwijnand Dec 31, 2015

Choose a reason for hiding this comment

Uh oh!

smarter Dec 31, 2015

Choose a reason for hiding this comment

Uh oh!

dwijnand Dec 31, 2015

Choose a reason for hiding this comment

Uh oh!

dwijnand commented Dec 31, 2015

Uh oh!

smarter commented Dec 31, 2015

Uh oh!

SethTisue commented Dec 31, 2015

Uh oh!

smarter commented Dec 31, 2015

Uh oh!

smarter commented Dec 31, 2015

Uh oh!

eed3si9n commented Dec 31, 2015

Uh oh!

smarter commented Jan 3, 2016

Uh oh!

eed3si9n commented Jan 4, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants