Add useJCenter settings and set it to false by default#2335
Merged
Conversation
Adds a new setting `useJCenter`, which is set to `false` by default. When set to `true`, JCenter will be placed as the first external resolver to find library dependencies. The implementation of `externalResolvers` is changed to incorporate the setting by calling `Resolver.reorganizeAppResolvers`. These changes were required because `externalResolvers` uses whatever that's in the launchconfig, which the build user may not upgrade.
Member
|
LGTM. Thanks. |
Contributor
|
👍 |
eed3si9n
added a commit
that referenced
this pull request
Dec 26, 2015
Add useJCenter settings and set it to false by default
This was referenced Jan 7, 2016
This was referenced Jan 16, 2016
| externalResolvers <<= (externalResolvers.task.?, resolvers, appResolvers, useJCenter) { | ||
| case (Some(delegated), Seq(), _, _) => delegated | ||
| case (_, rs, Some(ars), uj) => task { ars ++ Resolver.reorganizeAppResolvers(rs, uj, true) } | ||
| case (_, rs, _, uj) => task { Resolver.withDefaultResolvers(rs, uj) } |
Member
There was a problem hiding this comment.
death by booleans.. this is using useJCenter as the value of mavenCentral..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2217
what this changes
Adds a new setting
useJCenter, which is set tofalseby default. When set totrue, JCenter will be placed as the first external resolver to find library dependencies.The implementation of
externalResolversis changed to incorporate the setting by callingResolver.reorganizeAppResolvers. These changes were required becauseexternalResolversuses whatever that's in the launchconfig, which the build user may not upgrade.notes
sbt 0.13.9 made JCenter the first external resolver "for faster resolution times". #1938 (9261652.
From what I tested using Reactive Maps + Play 2.3.10, JCenter takes 212 ~ 251s for update to return on the proper build (excluding plugins) while Maven Central takes 71 ~ 98s for update. Basically 2 ~ 3.5 times slower. ymmv.
/review @Duhemm, @dwijnand, @jsuereth