Do not compute name hashes for private members. by gkossakowski · Pull Request #2325 · sbt/sbt

gkossakowski · 2015-12-18T22:37:55Z

The NameHashing classes assumed that extracted API data structure have private members filtered out already. That assumption was wrong and resulted in bug #2324.

We fix the bug by simply reusing the same logic as used by SameAPI class.

Fixes #2324.

Add a pending test that shows a bug in calculation of name hashes. By design, only non-private members should contribute to name hashes. The test shows that name hashes are calcuclated for strictly private members too.

Mention that private members are being extracted and included in the api structures but ignored in many other parts of incremental compiler. I've made a mistake of assuming that private members are ignored at api extraction time. This manifested itself as bug sbt#2324.

The NameHashing classes assumed that extracted API data structure have private members filtered out already. That assumption was wrong and resulted in bug sbt#2324. We fix the bug by simply reusing the same logic as used by SameAPI class. Fixes sbt#2324.

adriaanm · 2015-12-18T22:40:50Z

compile/api/src/main/scala/xsbt/api/APIUtil.scala

What's p.qualifier for private[this]?

Ah, I see, it's not an IdQualifier

typesafe-tools · 2015-12-18T22:41:04Z

Can one of the admins verify this patch?

adriaanm · 2015-12-19T00:08:30Z

Looks like spurious failure?

dwijnand · 2015-12-19T00:13:27Z

Indeed. Restarted the 2 jobs

eed3si9n · 2015-12-19T05:07:16Z

I just want to make sure that this change won't undo #2160 (Include private members in API hash of traits) that @Duhemm added this summer. I'm guessing it's ok since the spec is passing.

adriaanm · 2015-12-21T19:56:03Z

This causes a weird java.io.NotSerializableException: sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl:

[...]
    at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:348)
    at xsbt.api.SourceFormat$.writes(SourceFormat.scala:24)
    at xsbt.api.SourceFormat$.writes(SourceFormat.scala:15)
    at sbt.inc.TextAnalysisFormat$ObjectStringifier$$anonfun$objToString$1.apply$mcV$sp(TextAnalysisFormat.scala:329)
    at sbt.inc.TextAnalysisFormat$ObjectStringifier$$anonfun$objToString$1.apply(TextAnalysisFormat.scala:329)
    at sbt.inc.TextAnalysisFormat$ObjectStringifier$$anonfun$objToString$1.apply(TextAnalysisFormat.scala:329)
    at sbt.inc.FormatTimer$.aggregate(TextAnalysisFormat.scala:18)
    at sbt.inc.TextAnalysisFormat$ObjectStringifier$.objToString(TextAnalysisFormat.scala:329)
    at sbt.inc.TextAnalysisFormat$APIsF$$anonfun$15.apply(TextAnalysisFormat.scala:213)
    at sbt.inc.TextAnalysisFormat$APIsF$$anonfun$15.apply(TextAnalysisFormat.scala:213)
    at sbt.inc.TextAnalysisFormat$$anonfun$sbt$inc$TextAnalysisFormat$$writeMap$1.apply(TextAnalysisFormat.scala:381)
    at sbt.inc.TextAnalysisFormat$$anonfun$sbt$inc$TextAnalysisFormat$$writeMap$1.apply(TextAnalysisFormat.scala:377)
    at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
    at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47)
    at sbt.inc.TextAnalysisFormat$.sbt$inc$TextAnalysisFormat$$writeMap(TextAnalysisFormat.scala:377)
    at sbt.inc.TextAnalysisFormat$APIsF$.write(TextAnalysisFormat.scala:216)
    at sbt.inc.TextAnalysisFormat$$anonfun$write$4.apply$mcV$sp(TextAnalysisFormat.scala:64)
    at sbt.inc.TextAnalysisFormat$$anonfun$write$4.apply(TextAnalysisFormat.scala:64)
    at sbt.inc.TextAnalysisFormat$$anonfun$write$4.apply(TextAnalysisFormat.scala:64)
    at sbt.inc.FormatTimer$.aggregate(TextAnalysisFormat.scala:18)
    at sbt.inc.FormatTimer$.time(TextAnalysisFormat.scala:25)
    at sbt.inc.TextAnalysisFormat$.write(TextAnalysisFormat.scala:64)
    at sbt.inc.FileBasedStore$$anon$1$$anonfun$set$1.apply(FileBasedStore.scala:12)
    at sbt.inc.FileBasedStore$$anon$1$$anonfun$set$1.apply(FileBasedStore.scala:12)
    at sbt.Using.apply(Using.scala:24)
    at sbt.inc.FileBasedStore$$anon$1.set(FileBasedStore.scala:12)
    at sbt.inc.AnalysisStore$$anon$1.set(AnalysisStore.scala:16)
    at sbt.inc.AnalysisStore$$anon$2.set(AnalysisStore.scala:27)
    at sbt.Defaults$$anonfun$compileTask$1.apply(Defaults.scala:799)

while compiling the following Java file:

public class Outer { private class T extends Thread {} }

The crash manifested as a `NotSerializableException`, because we don't visit the private subtrees of the API graph, which would previously force all Lazy stubs as a side-effect. There was a backstop in `AbstractLazy` (`writeReplace`), but somehow that didn't work. ``` java.io.NotSerializableException: sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl [...] at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:329) at xsbt.api.SourceFormat$.writes(SourceFormat.scala:24) at xsbt.api.SourceFormat$.writes(SourceFormat.scala:15) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:329) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:329) at sbt.inc.TextAnalysisFormat21661anonfun at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.javr$.aggregate(TextAnalysisFormat.scala:18) at sbt.inc.TextAnalysisFormat$.objToString(TextAnalysisFormat.scala:329) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:213) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:213) at sbt.inc.TextAnalysisFormat21661anonfun21661writeMap.apply(TextAnalysisFormat.scala:381) at sbt.inc.TextAnalysisFormat21661anonfun21661writeMap.apply(TextAnalysisFormat.scala:377) at scala.collection.mutable.ResizableArray.foreach(Resizable at sbt.inc.TextAnalysisFormalection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at sbt.inc.TextAnalysisFormat$.sbt21661writeMap(TextAnalysisFormat.scala:377) at sbt.inc.TextAnalysisFormat$.write(TextAnalysisFormat.scala:216) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:64) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:64) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:64) at sbt.inc.FormatTimer$.aggregate(TextAnalysisFo at sbt.inc.TextAnalysisFormat21661anonfun.scala:25) at sbt.inc.TextAnalysisFormat$.write(TextAnalysisFormat.scala:64) at sbt.inc.FileBasedStore21661anon21661anonfun.apply(FileBasedStore.scala:12) at sbt.inc.FileBasedStore21661anon21661anonfun.apply(FileBasedStore.scala:12) at sbt.Using.apply(Using.scala:24) at sbt.inc.FileBasedStore21661anon.set(FileBasedStore.scala:12) at sbt.inc.AnalysisStore21661anon.set(AnalysisStore.scala:16) at sbt.inc.AnalysisStore21661anon.set(AnalysisStore.scala:27) at sbt.Defaults21661anonfun.apply(Defaults.scala:799) at sbt.Defaults21661anonfun at sbt.inc.TextAts.scala:793) at scala.Function121661anonfun.apply(Function1.scala:47) at sbt.21661anonfun21661u2219.apply(TypeFunctions.scala:40) at sbt.std.Transform21661anon.work(System.scala:63) at sbt.Execute21661anonfun21661anonfun.apply(Execute.scala:226) at sbt.Execute21661anonfun21661anonfun.apply(Execute.scala:226) at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17) at sbt.Execute.work(Execute.scala:235) at sbt.Execute21661anonfun.apply(Exe at sbt.Using.apply(Using.scala:24) mit.apply(Execute.scala:226) at sbt.ConcurrentRestrictions21661anon21661anonfun.apply(ConcurrentRestrictions.scala:159) at sbt.CompletionService21661anon.call(CompletionService.scala:28) at java.util.concurrent.FutureTask.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.Executors.call(Executors.java:439) at java.util.concurrent.FutureTask.innerRun(FutureTask.java:303 at sbt.std.Transform21661anon.work(System(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor.runTask(ThreadPoolExecutor.java:895) at java.util.concurrent.ThreadPoolExecutor.run(ThreadPoolExecutor.java:918) at java.lang.Thread.run(Thread.java:695) [error] (compile:compile) java.io.NotSerializableException: sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl [error] Total time: 2 s, completed Dec 21, 2015 12:05:19 PM ```

Fix for regression triggered by sbt#2325 Somehow the old way of implementing `writeReplace` didn't work. The fix is captured, indirectly, by the scripted test `source-dependencies/java-analysis-serialization-error`.

The crash manifested as a `NotSerializableException`, because we don't visit the private subtrees of the API graph, which would previously force all Lazy stubs as a side-effect. There was a backstop in `AbstractLazy` (`writeReplace`), but somehow that didn't work. ``` java.io.NotSerializableException: sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl [...] at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:329) at xsbt.api.SourceFormat$.writes(SourceFormat.scala:24) at xsbt.api.SourceFormat$.writes(SourceFormat.scala:15) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:329) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:329) at sbt.inc.TextAnalysisFormat21661anonfun at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.javr$.aggregate(TextAnalysisFormat.scala:18) at sbt.inc.TextAnalysisFormat$.objToString(TextAnalysisFormat.scala:329) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:213) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:213) at sbt.inc.TextAnalysisFormat21661anonfun21661writeMap.apply(TextAnalysisFormat.scala:381) at sbt.inc.TextAnalysisFormat21661anonfun21661writeMap.apply(TextAnalysisFormat.scala:377) at scala.collection.mutable.ResizableArray.foreach(Resizable at sbt.inc.TextAnalysisFormalection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at sbt.inc.TextAnalysisFormat$.sbt21661writeMap(TextAnalysisFormat.scala:377) at sbt.inc.TextAnalysisFormat$.write(TextAnalysisFormat.scala:216) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:64) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:64) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:64) at sbt.inc.FormatTimer$.aggregate(TextAnalysisFo at sbt.inc.TextAnalysisFormat21661anonfun.scala:25) at sbt.inc.TextAnalysisFormat$.write(TextAnalysisFormat.scala:64) at sbt.inc.FileBasedStore21661anon21661anonfun.apply(FileBasedStore.scala:12) at sbt.inc.FileBasedStore21661anon21661anonfun.apply(FileBasedStore.scala:12) at sbt.Using.apply(Using.scala:24) at sbt.inc.FileBasedStore21661anon.set(FileBasedStore.scala:12) at sbt.inc.AnalysisStore21661anon.set(AnalysisStore.scala:16) at sbt.inc.AnalysisStore21661anon.set(AnalysisStore.scala:27) at sbt.Defaults21661anonfun.apply(Defaults.scala:799) at sbt.Defaults21661anonfun at sbt.inc.TextAts.scala:793) at scala.Function121661anonfun.apply(Function1.scala:47) at sbt.21661anonfun21661u2219.apply(TypeFunctions.scala:40) at sbt.std.Transform21661anon.work(System.scala:63) at sbt.Execute21661anonfun21661anonfun.apply(Execute.scala:226) at sbt.Execute21661anonfun21661anonfun.apply(Execute.scala:226) at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17) at sbt.Execute.work(Execute.scala:235) at sbt.Execute21661anonfun.apply(Exe at sbt.Using.apply(Using.scala:24) mit.apply(Execute.scala:226) at sbt.ConcurrentRestrictions21661anon21661anonfun.apply(ConcurrentRestrictions.scala:159) at sbt.CompletionService21661anon.call(CompletionService.scala:28) at java.util.concurrent.FutureTask.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.Executors.call(Executors.java:439) at java.util.concurrent.FutureTask.innerRun(FutureTask.java:303 at sbt.std.Transform21661anon.work(System(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor.runTask(ThreadPoolExecutor.java:895) at java.util.concurrent.ThreadPoolExecutor.run(ThreadPoolExecutor.java:918) at java.lang.Thread.run(Thread.java:695) [error] (compile:compile) java.io.NotSerializableException: sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl [error] Total time: 2 s, completed Dec 21, 2015 12:05:19 PM ```

Fix for regression triggered by sbt#2325 Somehow the old way of implementing `writeReplace` didn't work. The fix is captured, indirectly, by the scripted test `source-dependencies/java-analysis-serialization-error`.

adriaanm · 2015-12-22T02:57:20Z

@gkossakowski, I submitted a PR to your PR with a test & fix for a regression uncovered by your fix.

Fix for regression triggered by sbt#2325 From https://docs.oracle.com/javase/7/docs/api/java/io/Serializable.html `writeReplace` must be protected for its override to be inherited. > `Serializable` classes that need to designate an alternative object to be used > when writing an object to the stream should implement this special method with > the exact signature: > `ANY-ACCESS-MODIFIER Object writeReplace() throws ObjectStreamException;` > > This `writeReplace` method is invoked by serialization if the method exists and > it would be accessible from a method defined within the class of the object > being serialized. Thus, the method can have `private`, `protected` and > `package-private` access. > > **Subclass access to this method follows java accessibility rules.** (Thanks to retronym for digging up the docs.) The fix is captured, indirectly, by the scripted test `source-dependencies/java-analysis-serialization-error`.

Fix for regression triggered by sbt#2325 -- apparently, the API visitor would force all the lazy stubs so the `AbstractLazy` `writeReplace` was not exercised. With the private subtrees being ignored, the visitor didn't force the lazy stub, and the `writeProtected` method was not inherited in `SafeLazy.Impl`. From https://docs.oracle.com/javase/7/docs/api/java/io/Serializable.html `writeReplace` must be protected for its override to be inherited. > `Serializable` classes that need to designate an alternative object to be used > when writing an object to the stream should implement this special method with > the exact signature: > `ANY-ACCESS-MODIFIER Object writeReplace() throws ObjectStreamException;` > > This `writeReplace` method is invoked by serialization if the method exists and > it would be accessible from a method defined within the class of the object > being serialized. Thus, the method can have `private`, `protected` and > `package-private` access. > > **Subclass access to this method follows java accessibility rules.** (Thanks to retronym for digging up the docs.) The fix is captured, indirectly, by the scripted test `source-dependencies/java-analysis-serialization-error`.

The crash manifested as a `NotSerializableException`, because we don't visit the private subtrees of the API graph, which would previously force all Lazy stubs as a side-effect. There was a backstop in `AbstractLazy` (`writeReplace`), but somehow that didn't work. ``` java.io.NotSerializableException: sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl [...] at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:329) at xsbt.api.SourceFormat$.writes(SourceFormat.scala:24) at xsbt.api.SourceFormat$.writes(SourceFormat.scala:15) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:329) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:329) at sbt.inc.TextAnalysisFormat21661anonfun at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.javr$.aggregate(TextAnalysisFormat.scala:18) at sbt.inc.TextAnalysisFormat$.objToString(TextAnalysisFormat.scala:329) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:213) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:213) at sbt.inc.TextAnalysisFormat21661anonfun21661writeMap.apply(TextAnalysisFormat.scala:381) at sbt.inc.TextAnalysisFormat21661anonfun21661writeMap.apply(TextAnalysisFormat.scala:377) at scala.collection.mutable.ResizableArray.foreach(Resizable at sbt.inc.TextAnalysisFormalection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:47) at sbt.inc.TextAnalysisFormat$.sbt21661writeMap(TextAnalysisFormat.scala:377) at sbt.inc.TextAnalysisFormat$.write(TextAnalysisFormat.scala:216) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:64) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:64) at sbt.inc.TextAnalysisFormat21661anonfun.apply(TextAnalysisFormat.scala:64) at sbt.inc.FormatTimer$.aggregate(TextAnalysisFo at sbt.inc.TextAnalysisFormat21661anonfun.scala:25) at sbt.inc.TextAnalysisFormat$.write(TextAnalysisFormat.scala:64) at sbt.inc.FileBasedStore21661anon21661anonfun.apply(FileBasedStore.scala:12) at sbt.inc.FileBasedStore21661anon21661anonfun.apply(FileBasedStore.scala:12) at sbt.Using.apply(Using.scala:24) at sbt.inc.FileBasedStore21661anon.set(FileBasedStore.scala:12) at sbt.inc.AnalysisStore21661anon.set(AnalysisStore.scala:16) at sbt.inc.AnalysisStore21661anon.set(AnalysisStore.scala:27) at sbt.Defaults21661anonfun.apply(Defaults.scala:799) at sbt.Defaults21661anonfun at sbt.inc.TextAts.scala:793) at scala.Function121661anonfun.apply(Function1.scala:47) at sbt.21661anonfun21661u2219.apply(TypeFunctions.scala:40) at sbt.std.Transform21661anon.work(System.scala:63) at sbt.Execute21661anonfun21661anonfun.apply(Execute.scala:226) at sbt.Execute21661anonfun21661anonfun.apply(Execute.scala:226) at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17) at sbt.Execute.work(Execute.scala:235) at sbt.Execute21661anonfun.apply(Exe at sbt.Using.apply(Using.scala:24) mit.apply(Execute.scala:226) at sbt.ConcurrentRestrictions21661anon21661anonfun.apply(ConcurrentRestrictions.scala:159) at sbt.CompletionService21661anon.call(CompletionService.scala:28) at java.util.concurrent.FutureTask.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.Executors.call(Executors.java:439) at java.util.concurrent.FutureTask.innerRun(FutureTask.java:303 at sbt.std.Transform21661anon.work(System(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor.runTask(ThreadPoolExecutor.java:895) at java.util.concurrent.ThreadPoolExecutor.run(ThreadPoolExecutor.java:918) at java.lang.Thread.run(Thread.java:695) [error] (compile:compile) java.io.NotSerializableException: sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl [error] Total time: 2 s, completed Dec 21, 2015 12:05:19 PM ```

Fix for regression triggered by sbt#2325 -- apparently, the API visitor would force all the lazy stubs so the `AbstractLazy` `writeReplace` was not exercised. With the private subtrees being ignored, the visitor didn't force the lazy stub, and the `writeProtected` method was not inherited in `SafeLazy.Impl`. From https://docs.oracle.com/javase/7/docs/api/java/io/Serializable.html `writeReplace` must be protected for its override to be inherited. > `Serializable` classes that need to designate an alternative object to be used > when writing an object to the stream should implement this special method with > the exact signature: > `ANY-ACCESS-MODIFIER Object writeReplace() throws ObjectStreamException;` > > This `writeReplace` method is invoked by serialization if the method exists and > it would be accessible from a method defined within the class of the object > being serialized. Thus, the method can have `private`, `protected` and > `package-private` access. > > **Subclass access to this method follows java accessibility rules.** (Thanks to retronym for digging up the docs.) The fix is captured, indirectly, by the scripted test `source-dependencies/java-analysis-serialization-error`.

…-members Test & fix for regression in Lazy serialization uncovered by sbt#2325

gkossakowski · 2015-12-23T00:13:55Z

@eed3si9n, your worry about preserving treatment of private members in traits is warranted. I'll settle it with adding a functional (scripted) test for it.

gkossakowski · 2015-12-23T01:15:37Z

I realized there's a scripted test for private members in traits and it's been marked as passing by #2160. We're good here. I think we're good to go.

Add a test that shows the scenario described in sbt#2324 is handled correctly now.

…sakowski/sbt into nameHashing/private-members

eed3si9n · 2015-12-29T05:22:28Z

cadacy failure seems to be false positive. LGTM

Do not compute name hashes for private members.

Release note for #2325

gkossakowski added 3 commits December 18, 2015 14:05

Add pending test for sbt#2324 (name hashes of private members)

ae2ddab

Add a pending test that shows a bug in calculation of name hashes. By design, only non-private members should contribute to name hashes. The test shows that name hashes are calcuclated for strictly private members too.

eed3si9n added the in progress label Dec 18, 2015

gkossakowski added the area/incremental_compiler label Dec 18, 2015

adriaanm reviewed Dec 18, 2015
View reviewed changes

adriaanm added a commit to adriaanm/sbt that referenced this pull request Dec 20, 2015

Backport sbt#2325

1f5e637

adriaanm mentioned this pull request Dec 20, 2015

WIP: 0.13.8 backports adriaanm/sbt#2

Open

adriaanm added a commit to adriaanm/sbt that referenced this pull request Dec 21, 2015

Merge sbt#2325 Do not compute name hashes for private members.

e067d50

adriaanm mentioned this pull request Dec 21, 2015

Assorted incremental compiler bug fixes. adriaanm/sbt#1

Open

adriaanm and others added 3 commits December 21, 2015 22:19

Merge pull request #10 from adriaanm/gkossakowski-nameHashing/private…

b76db70

…-members Test & fix for regression in Lazy serialization uncovered by sbt#2325

gkossakowski added 2 commits December 23, 2015 14:17

Add scripted (functional test) for sbt#2324.

3a6b6aa

Add a test that shows the scenario described in sbt#2324 is handled correctly now.

Merge branch 'nameHashing/private-members' of https://github.com/gkos…

d2aeff3

…sakowski/sbt into nameHashing/private-members

eed3si9n added a commit that referenced this pull request Dec 29, 2015

Merge pull request #2325 from gkossakowski/nameHashing/private-members

c5b0c7b

Do not compute name hashes for private members.

eed3si9n merged commit c5b0c7b into sbt:0.13 Dec 29, 2015

eed3si9n removed the in progress label Dec 29, 2015

eed3si9n added a commit that referenced this pull request Dec 29, 2015

Release note for #2325

fd347f0

eed3si9n added a commit that referenced this pull request Dec 30, 2015

Merge pull request #2339 from sbt/wip/2325_notes

5ba7352

Release note for #2325

gkossakowski mentioned this pull request Jan 4, 2016

Name hashing invalidation is sensitive to private members #2324

Closed

eed3si9n mentioned this pull request Jan 7, 2016

Forward port sbt/sbt#2325 sbt/zinc#45

Closed

gkossakowski deleted the nameHashing/private-members branch January 7, 2016 16:34

eed3si9n mentioned this pull request Jan 7, 2016

[sbt 1.0] Forward port 0.13 changes #2352

Closed

7 tasks

dwijnand mentioned this pull request Jan 16, 2016

FPORT: Do not compute name hashes for private members. sbt/zinc#46

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Do not compute name hashes for private members.#2325

Do not compute name hashes for private members.#2325
eed3si9n merged 8 commits intosbt:0.13from
gkossakowski:nameHashing/private-members

gkossakowski commented Dec 18, 2015

Uh oh!

adriaanm Dec 18, 2015

Uh oh!

adriaanm Dec 21, 2015

Uh oh!

typesafe-tools commented Dec 18, 2015

Uh oh!

adriaanm commented Dec 19, 2015

Uh oh!

dwijnand commented Dec 19, 2015

Uh oh!

eed3si9n commented Dec 19, 2015

Uh oh!

adriaanm commented Dec 21, 2015

Uh oh!

adriaanm commented Dec 22, 2015

Uh oh!

gkossakowski commented Dec 23, 2015

Uh oh!

gkossakowski commented Dec 23, 2015

Uh oh!

eed3si9n commented Dec 29, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

gkossakowski commented Dec 18, 2015

Uh oh!

adriaanm Dec 18, 2015

Choose a reason for hiding this comment

Uh oh!

adriaanm Dec 21, 2015

Choose a reason for hiding this comment

Uh oh!

typesafe-tools commented Dec 18, 2015

Uh oh!

adriaanm commented Dec 19, 2015

Uh oh!

dwijnand commented Dec 19, 2015

Uh oh!

eed3si9n commented Dec 19, 2015

Uh oh!

adriaanm commented Dec 21, 2015

Uh oh!

adriaanm commented Dec 22, 2015

Uh oh!

gkossakowski commented Dec 23, 2015

Uh oh!

gkossakowski commented Dec 23, 2015

Uh oh!

eed3si9n commented Dec 29, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants