Fixes #1514. Enable latest SNAPSHOT option by default#2313
Merged
Conversation
#1520 originally fixed #1514 by reimplementing part of chain resolver to check all resolvers to find the latest snapshot artifacts. This behavior did not work well with Maven repositories where sbt was failing to calculate the correct publication dates. Now that #2075 fixes the Maven integration issue we should enable this flag back again. The build user can opt out by: updateOptions := updateOptions.value.withLatestSnapshots(false)
Member
Author
There was a problem hiding this comment.
This option has gone back and forth, so I am leaving that in in case we're going to default it to false again.
Member
|
LGTM asides from the minor commented code comment |
The "latest snapshot" chain resolver was assuming that there's at least one artifact per module. I think that was the root cause of #1616.
eed3si9n
added a commit
that referenced
this pull request
Dec 30, 2015
Fixes #1514. Enable latest SNAPSHOT option by default
7 tasks
This was referenced Jan 17, 2016
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1514
Fixes #1616
#1520 originally fixed #1514 by reimplementing part of chain resolver to check all resolvers to find the latest snapshot artifacts. This behavior did not work well:
Fixes #2005. Bump to ivy 2.3.0-sbt-c5d1b95fdcc1e1007740ffbecf4eb07abc… #2075 should fix the publication date issue, and we should enable this flag back again. 1bf789e fixes the module without artifacts.
The build user can opt out by:
/review @jsuereth, @dwijnand, @Duhemm