Conversation
… default. The checking code has bad run time characteristics and would need to be fixed for large projects with deep task dependency chains. The code in sbt.Execute has been in production for a long time so it seems safe enough to drop the extra checks by default. To debug issues, you can set `-Dsbt.execute.extrachecks=true` to revert to the old behavior.
Member
Author
|
/cc @fommil |
|
Can one of the admins verify this patch? |
Member
|
LGTM pending Travis. |
Contributor
|
hmm, where is your repo @jrudolph ? |
Contributor
|
oh wow, your fork is |
Contributor
|
not sure about "fixes" but this certainly improves things! I'm seeing an |
Member
|
Could you also add a release not entry in https://github.com/sbt/sbt/tree/0.13/notes/0.13.10? |
eed3si9n
added a commit
that referenced
this pull request
Dec 14, 2015
…ecks Fixes #2302. Don't check pre and post conditions in sbt.Execute by default
eed3si9n
added a commit
that referenced
this pull request
Dec 15, 2015
7 tasks
Member
Author
|
I now have a build that just hangs which would have failed with an assertion without this change. Maybe the assertion that notices that no tasks are runnable any more should be enabled in any case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checking code has bad run time characteristics and would need to be fixed for large projects with deep task dependency chains.
The code in sbt.Execute has been in production for a long time so it seems safe enough to drop the extra checks by default. To debug issues, you can set
-Dsbt.execute.extrachecks=trueto revert to the old behavior.Fixes #2302.