Conversation
sbt was reporting warning abouts inconsistent versions of dependencies even if these dependencies didn't have the same configuration (as in `provided` vs `compile`). This commit fixes this problem by comparing the dependencies by organization, artifact name and configuration. Fixes sbt#1933
|
Can one of the admins verify this patch? |
Member
|
Nice! Should this target 0.13? Also, would be great to have release notes for this. |
Contributor
Author
|
Good catch! I just added the notes. I think @eed3si9n would like to release a 0.13.10 at some point |
Member
|
I was thinking about 0.13.10 but it may or may not happen. |
Member
|
@Duhemm Could you send the same PR to sbt/librarymanagement? |
Duhemm
added a commit
to Duhemm/librarymanagement
that referenced
this pull request
Nov 11, 2015
(This is a port of sbt/sbt#2258) sbt was reporting warning abouts inconsistent versions of dependencies even if these dependencies didn't have the same configuration (as in `provided` vs `compile`). This commit fixes this problem by comparing the dependencies by organization, artifact name and configuration.
|
Thanks for the fix! Is there any plans to release |
Member
|
@max-voloshin See @eed3si9n's very recent answer: #2256 (comment) |
|
@dwijnand thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sbt was reporting warning abouts inconsistent versions of dependencies
even if these dependencies didn't have the same configuration (as in
providedvscompile).This commit fixes this problem by comparing the dependencies by
organization, artifact name and configuration.
Fixes #1933