Use getPosition method to get an offset position instead of using a line number#2201
Conversation
|
Can one of the admins verify this patch? |
Member
|
Could you also send the same pull request to https://github.com/sbt/incrementalcompiler please? |
Author
|
@eed3si9n done: sbt/zinc#11 |
Member
|
LGTM pending Travis. |
Author
|
Travis is green |
eed3si9n
added a commit
that referenced
this pull request
Sep 11, 2015
Use getPosition method to get an offset position instead of using a line number
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing changes from #2108 it appeared that getLine method takes an absolute offset instead of a line number. Thankfully there is getPosition method to get a position of a report.