Skip to content

Compiler interface sources: Hide Ivy logs & download compiler interface sources in boot directory.#2177

Merged
eed3si9n merged 2 commits intosbt:0.13from
Duhemm:compiler-interface-logging
Aug 26, 2015
Merged

Compiler interface sources: Hide Ivy logs & download compiler interface sources in boot directory.#2177
eed3si9n merged 2 commits intosbt:0.13from
Duhemm:compiler-interface-logging

Conversation

@Duhemm
Copy link
Contributor

@Duhemm Duhemm commented Aug 26, 2015

Replaces #2174.

The Ivy logs for retrieving the compiler interface sources will now:

  • Not show anything if some version of the compiler interface sources can be found, or
  • Show all the failures if nothing can be found.

This PR also fixes the download location of the compiler interface sources. They will now be downloaded under ~/.sbt/boot/scala-2.11.7/org.scala-sbt/sbt/0.13.10-SNAPSHOT/compiler-interface-srcs (for instance).

Duhemm added 2 commits August 26, 2015 09:40
Because in most cases there aren't version-specific sources, we expect
the retrieval to fail a number of times before succeeding. This
generates a lot of noise in sbt's log, so the logs will now be shown if
and only all the versions fail.
@typesafe-tools
Copy link

Can one of the admins verify this patch?

@eed3si9n
Copy link
Member

LGTM
Could you also send this to sbt/incrementalcompiler?

eed3si9n added a commit that referenced this pull request Aug 26, 2015
Compiler interface sources: Hide Ivy logs & download compiler interface sources in boot directory.
@eed3si9n eed3si9n merged commit fc7af22 into sbt:0.13 Aug 26, 2015
@eed3si9n eed3si9n removed the ready label Aug 26, 2015
@Duhemm
Copy link
Contributor Author

Duhemm commented Aug 27, 2015

@eed3si9n I've opened sbt/zinc#3. I'll do the same for #2160

eed3si9n added a commit to sbt/zinc that referenced this pull request Sep 8, 2015
@Duhemm Duhemm deleted the compiler-interface-logging branch January 27, 2016 08:11
dwijnand pushed a commit to dwijnand/sbt that referenced this pull request Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants