Can one of the admins verify this patch?

Copied from sbt/ivy#15, this is how I've been reproducing this bug:

• Stock Nexus installed with homebrew
• sbt-gh1750-bippy, the SNAPSHOT dependency
• sbt-gh1750-myapp, the project trying to get updated SNAPSHOT sources
• Change bippy, and publish to Nexus
• Run updateClassifiers in myapp, see if it downloads the sources jar
• As a second test, check the contents bippy:

unzip -c ~/.ivy2/cache/com.dwijnand/sbt-gh1750-bippy_2.11/srcs/sbt-gh1750-bippy_2.11-0.1.0-SNAPSHOT-sources.jar Bippy.scala

// sbt-gh1750-bippy/build.sbt

organization := "com.dwijnand"
        name := "sbt-gh1750-bippy"
     version := "0.1.0-SNAPSHOT"
scalaVersion := "2.11.7"

val localNexusReleases  = "local-nexus-releases"  at "http://localhost:8081/nexus/content/repositories/releases"
val localNexusSnapshots = "local-nexus-snapshots" at "http://localhost:8081/nexus/content/repositories/snapshots"
val localNexusCreds = Credentials("Sonatype Nexus Repository Manager", "localhost", "admin", "admin123")

publishTo := Some(if (isSnapshot.value) localNexusSnapshots else localNexusReleases)
credentials := Seq(localNexusCreds)

// sbt-gh1750-myapp/build.sbt
organization := "com.dwijnand"
        name := "sbt-gh1750-myapp"
     version := "0.1.0-SNAPSHOT"
scalaVersion := "2.11.7"

val localNexusReleases  = "local-nexus-releases"  at "http://localhost:8081/nexus/content/repositories/releases"
val localNexusSnapshots = "local-nexus-snapshots" at "http://localhost:8081/nexus/content/repositories/snapshots"

resolvers += localNexusReleases
resolvers += localNexusSnapshots

libraryDependencies += "com.dwijnand" %% "sbt-gh1750-bippy" % "0.1.0-SNAPSHOT"

Travis failed because sbt/ivy#17 hasn't been released (or merged) yet.

Rebased and force pushed.

Added a scripted test, which prior to the Ivy update fails and after passes(!).

However, as mentioned on Gitter, I needed a way to declare a local filesystem resolver that actually copied files out to the Ivy cache, instead of just using the file in place, so I could verify against what was resolved/downloaded.

So I've made a change to MavenRepository to allow for that. I've simulated and tested in a separated repo with MiMa that these are the changes necessary for bincompat, but please have a look.

I'm not sure if that flag needs notes. Also potentially I could split that change out of this pull request.

Still haven't written up notes for the fix itself; what do you think of it?

Commented on dwijnand/sbt@24495be

@eed3si9n I've added another commit as there was a failure in Travis that I'm not sure if it was legitimate or not.

What do you think of dwijnand@467e9ab? Note I added a comment below it as well.

Other than that, what do you think of this PR, the fix itself etc?

Hmm yeah... looks like my test doesn't work on Travis:

Failed to read jar /tmp/sbt_8f770495/update-classifiers-snapshot-srcs/target/ivy/cache/org.example/bippy_2.11/srcs/bippy_2.11-1.0-SNAPSHOT-sources.jar

Don't understand why though :-/

Travis is failing when using mavenResolverPlugin. I have a local change that fixes the pathing to sources jar, but running that test shows that the issue is still present when using that plugin.. :(

Travis passed! :)

LGTM

Uh... I was going to make the change discussed in sbt/ivy#17 and the relevant sbt changes here to enable the ivySettings flag..

I'll open a new PR in both repos with that change.

Also this was missing notes, so that'll be part of the follow up PR.