Replace procedure syntax by explicit Unit annotation#2139
Conversation
|
Can one of the admins verify this patch? |
Member
|
Nice work. LGTM. |
Member
Author
|
Fails to compile, though, made a typo... |
Member
Author
There was a problem hiding this comment.
Yep, fixed them as you wrote that comment :)
Member
|
Thanks for this! |
Member
|
I'm guessing that the Travis failures are just flaky tests, but I am restarting failed jobs to see if they pass. |
Member
Author
|
@eed3si9n Unfortunately, the'yre not, an issue on my side, fixing. |
Member
Author
|
@eed3si9n The next PR build should be green. |
Member
Author
|
Looks like it won't be green after all, but it's a "flaky" test: |
eed3si9n
added a commit
that referenced
this pull request
Aug 4, 2015
Replace procedure syntax by explicit Unit annotation
adriaanm
added a commit
to adriaanm/sbt
that referenced
this pull request
Dec 20, 2015
adriaanm
added a commit
to adriaanm/sbt
that referenced
this pull request
Dec 21, 2015
jvican
pushed a commit
to scalacenter/sbt
that referenced
this pull request
May 23, 2017
Replace procedure syntax by explicit Unit annotation
adpi2
pushed a commit
to adpi2/sbt
that referenced
this pull request
Oct 9, 2024
Replace procedure syntax by explicit Unit annotation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realize this ends up as a huge PR, I can break it down to smaller pieces if you like.