Skip to content

Fixes #1973. Renames distinct to distinctName#2079

Merged
eed3si9n merged 2 commits into0.13from
wip/distinct-rename
Jun 29, 2015
Merged

Fixes #1973. Renames distinct to distinctName#2079
eed3si9n merged 2 commits into0.13from
wip/distinct-rename

Conversation

@eed3si9n
Copy link
Member

Fixes #1973

/review @dwijnand, @jroper

@dwijnand
Copy link
Member

The change LGTM, but it doesn't really "fix" #1973.

Perhaps we should add a .distinctPath, which would solve #1973 (imo).

Also I agree with @jroper about the intuitive intent of .distinct and would argue that the deprecated message should point to .distinctPath (or maybe just indicate both).

@dwijnand
Copy link
Member

For reference, how @jroper worked around current .distinct: playframework/playframework#4236

@eed3si9n
Copy link
Member Author

What's the return type of distinctPath? PathFinder, Seq[String, or Seq[File]?

@dwijnand
Copy link
Member

PathFinder I would've thought.

@eed3si9n
Copy link
Member Author

Added it.

scala> import sbt._
import sbt._

scala> (file("src") ***).distinctPath
res0: sbt.PathFinder = 

   src/main
   src/main/conscript/sbt
   src/main/conscript/screpl/launchconfig
   src/main/conscript/screpl
   src
   src/main/conscript/scalas/launchconfig
   src/main/conscript/sbt/launchconfig
   src/main/conscript
   src/main/conscript/scalas

@dwijnand
Copy link
Member

Sweet. LGTM.

eed3si9n added a commit that referenced this pull request Jun 29, 2015
Fixes #1973. Renames distinct to distinctName
@eed3si9n eed3si9n merged commit f44f454 into 0.13 Jun 29, 2015
@eed3si9n eed3si9n deleted the wip/distinct-rename branch June 29, 2015 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants