Skip to content

Adds bundledLauncherProj to allProj#2057

Merged
eed3si9n merged 5 commits into0.13from
wip/fixbuild
Jun 21, 2015
Merged

Adds bundledLauncherProj to allProj#2057
eed3si9n merged 5 commits into0.13from
wip/fixbuild

Conversation

@eed3si9n
Copy link
Member

This matters when someone tries to locally build sbt from source.

/review @dwijnand, @jsuereth

@dwijnand
Copy link
Member

👍

Everything's used by sbtRoot now:

  • before: before
  • after: after

@eed3si9n
Copy link
Member Author

@jsuereth There's a legit failure introduced by #1938 (wrapped launcher).
launch directory contains tests, but because autoScalaLibrary is set to false, it's unable to compile the tests.

@jsuereth
Copy link
Member

Hmm, so we should remove the tests?

Your PR looks good to me

@eed3si9n
Copy link
Member Author

Yea. I'll try to split out the test into another subproject.

eed3si9n added a commit that referenced this pull request Jun 21, 2015
Adds bundledLauncherProj to allProj
@eed3si9n eed3si9n merged commit 01f1627 into 0.13 Jun 21, 2015
@eed3si9n eed3si9n deleted the wip/fixbuild branch June 21, 2015 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants