Skip to content

Provide more diagnostic info for undefined settings#2009

Merged
jsuereth merged 3 commits intosbt:0.13from
DavidPerezIngeniero:0.13
Jun 17, 2015
Merged

Provide more diagnostic info for undefined settings#2009
jsuereth merged 3 commits intosbt:0.13from
DavidPerezIngeniero:0.13

Conversation

@DavidPerezIngeniero
Copy link

This solves this issue:
#2008

This is my previous error message:

sbt.Init$RuntimeUndefined: References to undefined settings at runtime.

which doesn't tell me what is happening.

Now, I get this additional information:

setting(ScopedKey(Scope(Select(ProjectRef(file:/home/d/rds/,rds)),Global,Global,Global),testApi)) at RangePosition(/home/d/rds/build.sbt,LineRange(233,234)) referenced from ScopedKey(Scope(Select(ProjectRef(file:/home/d/rds/,servision)),Select(ConfigKey(api)),Global,Global),start)

Now I know where the problem lies! :-)

@typesafe-tools
Copy link

Can one of the admins verify this patch?

@dwijnand
Copy link
Member

dwijnand commented May 8, 2015

Nice turnaround :)

Perhaps it would be nicer if it were output some like (I hand-wrote this, I mean generally how sbt pretty prints settings):

{file:/home/d/rds/}rds/*:testApi at /home/d/rds/build.sbt:233 referenced from
{file:/home/d/rds/}servision/api:start at /home/d/rds/build.sbt:555

@DavidPerezIngeniero
Copy link
Author

Is there any existing API for that?

@dwijnand
Copy link
Member

dwijnand commented May 8, 2015

I don't know, but somewhere inspect outputs that.

On 8 May 2015 at 11:14, David Pérez Carmona notifications@github.com
wrote:

Is there any existing API for that?


Reply to this email directly or view it on GitHub
#2009 (comment).

@jsuereth
Copy link
Member

Yeah, some of the "API" is internal methods that should get turned into API. This is a a really nice improvement!

@jsuereth
Copy link
Member

LGTM, pending some "pretty printing" we may want to try.

@jsuereth
Copy link
Member

macro arg dep nested appears to be flaky.

@jsuereth
Copy link
Member

Would you mind rebasing this so we can get the travis tests passing? I'd like to merge it in.

Thanks!

  • Josh

@DavidPerezIngeniero
Copy link
Author

Sorry for the delay, I've been travelling and quite busy.

I've merged the latest SBT modifications on branch 0.13.

@jsuereth
Copy link
Member

Thanks!

jsuereth added a commit that referenced this pull request Jun 17, 2015
Provide more diagnostic info for undefined settings
@jsuereth jsuereth merged commit e681412 into sbt:0.13 Jun 17, 2015
@jsuereth jsuereth removed the ready label Jun 17, 2015
@dwijnand
Copy link
Member

do we want notes for this?

@eed3si9n
Copy link
Member

@dwijnand You can send a PR for a note or leave it. I probably left it alone when I was last checking all the commits.

eed3si9n added a commit that referenced this pull request Jun 28, 2015
adpi2 pushed a commit to adpi2/sbt that referenced this pull request Oct 9, 2024
Provide more diagnostic info for undefined settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants