Conversation
|
Can one of the admins verify this patch? |
Member
|
Nice! yes we should get a test. The right place is probably be in the "api" section of scripted tests. There is nothing specific to |
Member
|
Also, the code itself LGTM |
Member
|
@jroper woudl you mind rebasing this against master? Should clean up the PR validation failures. |
Member
Author
|
Rebased, tests written. |
Member
|
I give a grade I+ |
Member
|
Either now that this has just kicked off a Travis build, or if you want when it's done, notes plz! :D |
Member
|
LGTM pending release note (e.g. https://github.com/sbt/sbt/blob/8aca4e8fa6d4da9f31b267f2a8e503c147be237b/notes/0.13.9/force-gc.markdown) |
This provides a convenience function for running an input task from the extracted state. This is particularly useful for commands, release steps etc that may want to run input tasks, like scripted.
Member
Author
|
Release note added. |
Member
|
LGTM. Nice tests. |
adpi2
pushed a commit
to adpi2/sbt
that referenced
this pull request
Oct 9, 2024
Added Extracted.runInputTask
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This provides a convenience function for running an input task from the extracted state. This is particularly useful for commands, release steps etc that may want to run input tasks, like scripted.
I haven't added tests, because I'm not sure where the right place to test this is - I don't think any of the specs are applicable here unless there's any easy way to fire up a fake sbt project, so maybe a scripted test? But should it be an existing scripted test? If there is a right place, let me know, and I'll add a test there.