Skip to content

Roll back aggressive deletion of cache. Fixes #1091.#1234

Merged
jsuereth merged 1 commit into0.13from
wip/undo-nonsnapshot-deletion
Apr 5, 2014
Merged

Roll back aggressive deletion of cache. Fixes #1091.#1234
jsuereth merged 1 commit into0.13from
wip/undo-nonsnapshot-deletion

Conversation

@eed3si9n
Copy link
Member

@eed3si9n eed3si9n commented Apr 5, 2014

We should roll back 482f990 to fix #1091 (re-download of SNAPSHOTs). Rolling it back should not cause regression of #641 as confirmed by the scripted test scripted dependency-management/cache-classifiers and its externalized version eed3si9n/test-sbt-641.

@eed3si9n
Roll back sbt/sbt@482f99 (aggressive deletion of cache). Fixes #1091.
d8ee16c 
* sbt 0.12.3 introduced sbt/sbt@482f99 to fix #637 and #641.
* The underlying issue of #641 was an incorrect classifier, and it was
  fixed in sbt/sbt@718fa9 for #683 and shipped as sbt 0.13.0.
@jsuereth
Copy link
Member

jsuereth commented Apr 5, 2014

LGTM

jsuereth added a commit that referenced this pull request Apr 5, 2014
@jsuereth
Merge pull request #1234 from sbt/wip/undo-nonsnapshot-deletion
6f0289f 
Roll back aggressive deletion of cache. Fixes #1091.
@jsuereth jsuereth merged commit 6f0289f into 0.13 Apr 5, 2014
@jsuereth jsuereth deleted the wip/undo-nonsnapshot-deletion branch April 5, 2014 11:47
@xeno-by
Copy link

xeno-by commented Apr 5, 2014

Will this be part of 0.13.5?

@eed3si9n
Copy link
Member Author

eed3si9n commented Apr 5, 2014

Yea. 0.13 branch eventually becomes 0.13.5.

@lauris
Copy link

lauris commented May 11, 2014

I can't find any release that references this commit. Is it possible to use this fix now?

@eed3si9n
Copy link
Member Author

eed3si9n commented May 11, 2014

The commit is tagged 0.13.5-RC2, which I tagged on Friday. It'll stay RC for a week, and if no bugs are found it becomes 0.13.5.

@lauris
Copy link

lauris commented May 11, 2014

Thanks. Just upgraded to 0.13.5-RC2 and everythings works as expected.
On 11 May 2014 12:47, "eugene yokota" notifications@github.com wrote:

The commit is tagged 0.13.5-RC2, which I tagged on Friday. It'll stay RC
for a week, and if no bugs are found it becomes 0.13.5.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1234#issuecomment-42766391
.

This was referenced Aug 17, 2015
Closed
Merged
adpi2 pushed a commit to adpi2/sbt that referenced this pull request Oct 9, 2024
@jsuereth
Merge pull request sbt#1234 from sbt/wip/undo-nonsnapshot-deletion
9973307 
Roll back aggressive deletion of cache. Fixes sbt#1091.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eed3si9n @jsuereth @xeno-by @lauris