Merged
Conversation
SQL_SetCharset seems to be bugged and defaults to latin1
Contributor
|
This is very dumb fix ever i seen. |
|
And Sourcemod 1.9 and lower don't support utf8mb4. |
Contributor
|
Maybe instead of a hasty merging of PR, you give some time for another users for testing? Think about it, @Groruk. And, please, stop merging PR without reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #506
Close #505
Fix #236
Fix #390
Description
SQL_SetCharsetseems to be bugged and defaults tolatin1as a charset. To fix this we are now using "SET NAME" queries exclusively (until a fix for SQL_SetCharset is found)Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: