Skip to content

Emoji ban Fix 2#505

Closed
Ruok2bu wants to merge 1 commit intosbpp:v1.xfrom
Ruok2bu:patch-2
Closed

Emoji ban Fix 2#505
Ruok2bu wants to merge 1 commit intosbpp:v1.xfrom
Ruok2bu:patch-2

Conversation

@Ruok2bu
Copy link

@Ruok2bu Ruok2bu commented Aug 26, 2018

This fix changes the character set of the database so that players with Emoji's in their name can be banned. Since the source engine can't parse Emoji's, the value for the player's emoji is random text in the sourcebans database.

Description

Replaces all instances of utf8 with utf8mb4

Motivation and Context

Players with emoji in name could not be banned (because default character set configured by installer does not take into account the 4 bytes needed for emoji).

How Has This Been Tested?

I installed the plugin change on 10 servers.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

This fix changes the character set of the database so that players with Emoji's in their name can be banned. Since the source engine can't parse Emoji's, the value for the player's emoji is random text in the sourcebans database.

Sourcemod installer needs to be updated to use the following for database setup:
Character Set: utf8mb4
Collation: utf8mb4_unicode_ci
@Bara Bara mentioned this pull request Aug 27, 2018
7 tasks
@Groruk Groruk mentioned this pull request Nov 23, 2018
7 tasks
@Groruk Groruk closed this in #536 Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant