Skip to content

FbcModelPlugin C API for createObjective and createGeneProduct#252

Merged
skeating merged 1 commit intosbmlteam:developmentfrom
exaexa:mk-create-objects
Aug 4, 2022
Merged

FbcModelPlugin C API for createObjective and createGeneProduct#252
skeating merged 1 commit intosbmlteam:developmentfrom
exaexa:mk-create-objects

Conversation

@exaexa
Copy link
Copy Markdown
Contributor

@exaexa exaexa commented Jul 18, 2022

Description

Exposing some necessary functions for the C API

Motivation and Context

Same as with #247

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Change in documentation

Checklist:

  • I have updated all documentation necessary.
  • I have checked spelling in (new) comments.

Testing

  • Testing is done automatically and codecov shows test coverage
  • This cannot be tested automatically

exaexa added a commit to LCSB-BioCore/SBML.jl that referenced this pull request Jul 18, 2022
This depends on sbmlteam/libsbml#252 to be merged,
because some of the functions were actually not exposed to the C API.

Creating the members from the parent objects seems safer because all XML
metadata and versioning info gets automatically propagated. Also the code is a
bit shorter.
giordano pushed a commit to JuliaPackaging/Yggdrasil that referenced this pull request Jul 25, 2022
This adds code from sbmlteam/libsbml#252 to allow
development and deployment before upstream merges and releases the pathed
version.
@skeating skeating merged commit 00eb881 into sbmlteam:development Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants