fix: fix queue shuffle and dependent optimisation schemes#67
Merged
Neclow merged 5 commits intosbhattlab:fix_optfrom Jun 11, 2025
Merged
fix: fix queue shuffle and dependent optimisation schemes#67Neclow merged 5 commits intosbhattlab:fix_optfrom
Neclow merged 5 commits intosbhattlab:fix_optfrom
Conversation
Neclow
added a commit
that referenced
this pull request
Jun 11, 2025
* fix: fix queue shuffle and adapt tests * docs(rust): add comments in queue_shuffle * style: pre-commit fixes * docs: add more docs * fix: fix queue shuffle and dependent optimisation schemes (#67) * fix: fix queue shuffle and adapt tests * docs(rust): add comments in queue_shuffle * style: pre-commit fixes * docs: add more docs --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * refactor: make base class and hc class more consistent * Make base and HillClimbing classes more consistent (#68) * fix: fix queue shuffle and adapt tests * docs(rust): add comments in queue_shuffle * style: pre-commit fixes * docs: add more docs * refactor: make base class and hc class more consistent --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * refactor: fix gradme with new qs * docs: add more docs in gradme * even more docs! * style: pre-commit fixes * docs: add demo for optimisation (added to docs) + bump python version * style: pre-commit fixes * chore(codespell): exclude long strings from base64 images in notebooks * chore: reinstate my image in the demos --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
queue shufflework exactly as previous implementations (GradME and preprint). Added some more documentation in the core function and the test to reflect those changes, with examples of how the algorithm works.The change also removes cherry ordering from
from_ancestryandfrom_pairsto avoid uninteded side effects