Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the demo notebook to include explanations on Rust bindings, matrix format support, and I/O while introducing minor fixes to enforce consistency in return types. Key changes include adding the get_pairs function to the Python API, updating remove_leaf to return a numpy array, and modifying from_newick to always wrap its output in np.asarray.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| py-phylo2vec/src/lib.rs | Adds the get_pairs function and registers it in the Python API wrapper. |
| py-phylo2vec/phylo2vec/utils/vector.py | Updates remove_leaf to convert the returned vector to a numpy array. |
| py-phylo2vec/phylo2vec/base/newick.py | Revises from_newick to always return a numpy array for consistency. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10
Update demo notebook with explanation on Rust bindings, matrix format, and I/O.
Also introduces minor fixes, such as enforcing
from_newick,add_leaf,remove_leafto output a numpy array.And exposes
get_pairsto the Python API, although not included/wrapped anywhere yet.