feat(rs): use ryu float-to-string conversion#145
Merged
Neclow merged 1 commit intosbhattlab:mainfrom Oct 19, 2025
Merged
Conversation
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
~10-20% upgrade in build_newick_with_bls using faster float to string conversion with Ryū.
While this is slower for floats with few decimal (e.g., 0.1) than dtoa, I think arbitrary-like floats are more common in phylo, esp. when it comes to inference.
The library is a bit stricter to convert float (so 1.0 becomes '1.0' and not '1'), so had to modify rust and python tests.