Fixing reader creation logic in examples#21
Merged
satyrius merged 1 commit intosatyrius:masterfrom Oct 30, 2015
Merged
Conversation
Owner
|
Thank you for pull request! Could you drop binaries committed by accident? Then it will be merged to master. |
Previously the creation of an actual file used := to assign the file and err. This shadowed the var declaration of file, leaving it uninitialized and causing seg faults when the scanner tried to read data.
1096689 to
7a235fa
Compare
Author
|
ugh, sorry. Done. |
satyrius
added a commit
that referenced
this pull request
Oct 30, 2015
Fixing reader creation logic in examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the creation of an actual file used := to assign the file and err.
This shadowed the var declaration of file, leaving it uninitialized and causing
seg faults when the scanner tried to read data.