Merged
Conversation
Contributor
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
I made this change in some places, but didn't do it for things like loops through channels. As is, I went from 580 cases to 1800+, but there may be other places where specificity is worth it. |
nex3
requested changes
Nov 3, 2023
Contributor
nex3
left a comment
There was a problem hiding this comment.
Just a few style changes and I think we're ready to go!
jgerigmeyer
reviewed
Nov 6, 2023
js-api-spec/value/color.test.ts
Outdated
Comment on lines
+1742
to
+1758
| // Space conversions in ColorJS are close but not precise enough to match | ||
| skipForImpl('sass-embedded', () => { | ||
| describe('toSpace', () => { | ||
| spaceNames.forEach(destinationSpaceId => { | ||
| it(`converts pink to ${destinationSpaceId}`, () => { | ||
| const destinationSpace = spaces[destinationSpaceId]; | ||
| const res = color.toSpace(destinationSpace.name); | ||
| expect(res.space).toBe(destinationSpace.name); | ||
|
|
||
| const expected = destinationSpace.constructor( | ||
| ...destinationSpace.pink | ||
| ); | ||
| expect(res).toEqualWithHash(expected); | ||
| }); | ||
| }); | ||
| }); | ||
| }); |
Contributor
There was a problem hiding this comment.
@nex3 Using ColorJS to do color conversions works, but the math isn't precise enough to pass these tests, e.g.:
expected color(xyz-d50 0.66406985168935 0.5367266828656 0.43459579340121) to be .equal() to color(xyz-d50 0.6640698533004 0.53672666252811 0.43459582467203)
I'm not sure if we want to relax the precision requirements, or have different precision requirements for different platforms, or...?
nex3
approved these changes
Nov 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec: https://github.com/sass/sass/blob/main/proposal/color-4-new-spaces-js.d.ts.md
[skip dart-sass]
[skip sass-embedded]