[Color 4] Add JS type definitions and docs for CSS Color Level 4.#3718
Merged
nex3 merged 84 commits intosass:feature.color-4from Nov 17, 2023
Merged
[Color 4] Add JS type definitions and docs for CSS Color Level 4.#3718nex3 merged 84 commits intosass:feature.color-4from
nex3 merged 84 commits intosass:feature.color-4from
Conversation
* color-spaces-js-changes: Throw error if no space specified on non-legacy color change Fix channel names
* color-spaces-js-changes: Revert incorrect error
* color-spaces-js-changes: Address review
* color-spaces-js-changes: update changes
* color-spaces-js-changes-1.2: Tweak language around getters and arrays.
…e returning channel value.
* color-spaces-js-changes-1.5: Clarify that deprecated getters convert color to a legacy space before returning channel value.
nex3
requested changes
Nov 3, 2023
nex3
approved these changes
Nov 4, 2023
Contributor
|
Can you rebase this onto the |
* feature.color-4:
Contributor
Author
@nex3 Done, though I had already been basing this on |
* feature.color-4: [Shared Resources] Draft 1.2 (sass#3745)
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #3665
Blocked until https://github.com/sass/sass/blob/main/proposal/color-4-new-spaces-js.d.ts.md is accepted.