Skip to content

[Embedded Protocol] Disallow passing functions/mixins across compilations#4073

Merged
nex3 merged 1 commit intosass:mainfrom
ntkme:disallow-compiler-function-mixin-across-compilations
Apr 24, 2025
Merged

[Embedded Protocol] Disallow passing functions/mixins across compilations#4073
nex3 merged 1 commit intosass:mainfrom
ntkme:disallow-compiler-function-mixin-across-compilations

Conversation

@ntkme
Copy link
Copy Markdown
Contributor

@ntkme ntkme commented Apr 23, 2025

We already have language that implies this requirement:

// A first-class function defined in the compiler. New `CompilerFunction`s may
// only be created by the compiler, but the host may pass `CompilerFunction`s
// back to the compiler as long as their IDs match IDs of functions received
// by the host during that same compilation.
message CompilerFunction {

This PR adds an explicit requirement and high level instruction on how host side should handle this requirement.

@nex3 nex3 merged commit a3ca9ed into sass:main Apr 24, 2025
10 checks passed
@ntkme ntkme deleted the disallow-compiler-function-mixin-across-compilations branch April 24, 2025 23:14
Goodwine added a commit to sass/embedded-host-node that referenced this pull request May 7, 2025
The protocol version was updated in sass/sass#4073. The change was submitted, but this repo hasn't been updated. This repo requires matching the exact same value in https://github.com/sass/sass
Goodwine added a commit to sass/embedded-host-node that referenced this pull request May 8, 2025
The protocol version was updated in sass/sass#4073. The change was submitted, but this repo hasn't been updated. This repo requires matching the exact same value in https://github.com/sass/sass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants