[Color 4] Require case-sensitivity for all channel names#3851
Merged
nex3 merged 1 commit intofeature.color-4from Apr 25, 2024
Merged
[Color 4] Require case-sensitivity for all channel names#3851nex3 merged 1 commit intofeature.color-4from
nex3 merged 1 commit intofeature.color-4from
Conversation
This was already implicit in most cases, because all string comparisons are case-sensitive by default, but a few alpha comparisons were explicitly case-insensitive. This makes it more consistent as well as more explicit, and adds a design decision section discussing the reasoning.
f322757 to
3b08c19
Compare
nex3
added a commit
to sass/sass-spec
that referenced
this pull request
Apr 25, 2024
This also adds a missing case-sensitivity test for `is-powerless()`. See sass/sass#3851
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Apr 25, 2024
mirisuzanne
approved these changes
Apr 25, 2024
Goodwine
approved these changes
Apr 25, 2024
nex3
added a commit
that referenced
this pull request
Apr 25, 2024
This was already implicit in most cases, because all string comparisons are case-sensitive by default, but a few alpha comparisons were explicitly case-insensitive. This makes it more consistent as well as more explicit, and adds a design decision section discussing the reasoning.
nex3
added a commit
to sass/sass-spec
that referenced
this pull request
Apr 26, 2024
This also adds a missing case-sensitivity test for `is-powerless()`. See sass/sass#3851
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was already implicit in most cases, because all string
comparisons are case-sensitive by default, but a few alpha comparisons
were explicitly case-insensitive. This makes it more consistent as
well as more explicit, and adds a design decision section discussing
the reasoning.