Skip to content

Fix NodePackageImporter version compatibility#3788

Merged
nex3 merged 2 commits intosass:mainfrom
ntkme:nodepackageimporter
Feb 20, 2024
Merged

Fix NodePackageImporter version compatibility#3788
nex3 merged 2 commits intosass:mainfrom
ntkme:nodepackageimporter

Conversation

@ntkme
Copy link
Contributor

@ntkme ntkme commented Feb 16, 2024

https://sass-lang.com/documentation/js-api/classes/nodepackageimporter/ says it's compatible with Dart Sass since 2.0, this PR changes it to 1.71.0.

@ntkme
Copy link
Contributor Author

ntkme commented Feb 19, 2024

Link reference check is failing on https://stackoverflow.com/questions/tagged/sass in CI, but it works when testing locally. Maybe it's hitting rate limit from GitHub origin for unauthenticated requests, or maybe stackoverflow is blocking GitHub Actions' servers.

@nex3 nex3 self-requested a review February 20, 2024 21:12
@nex3 nex3 merged commit f5efdd6 into sass:main Feb 20, 2024
@ntkme ntkme deleted the nodepackageimporter branch February 20, 2024 23:00
nex3 added a commit that referenced this pull request Mar 27, 2024
Co-authored-by: Natalie Weizenbaum <nweiz@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants