Merged
Conversation
3 tasks
nex3
requested changes
Jan 19, 2024
Contributor
nex3
left a comment
There was a problem hiding this comment.
It's probably also a good idea to specify that new NodePackageImporter() throws an error if a path isn't passed and the default can't be loaded.
proposal/package-importer.d.ts.md
Outdated
| * A URL with non-empty/null username, password, host, port, query, or fragment. | ||
|
|
||
| If the conventions or specifications for an environment disallow any other URL | ||
| patterns, the Package Importer must not reject, and instead return `null`. This |
Contributor
There was a problem hiding this comment.
"reject" isn't a well-defined term here. I'd say "must return null rather than throwing an error."
Contributor
Author
Added in 517b1e2 |
nex3
approved these changes
Jan 20, 2024
jgerigmeyer
added a commit
to oddbird/sass
that referenced
this pull request
Jan 24, 2024
* main: [Package Importer] Draft 1.5 (sass#3777)
nex3
pushed a commit
that referenced
this pull request
Mar 27, 2024
* Specify no throws for package importer misses * Reject to throw error * Specify throw if no entry point * Fix whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/sass/dart-sass/pull/2130/files/e04b10982423d44237cb4d976c460e59478d731d#r1458161774