Add CompileRequest.silent to embedded protocol#3773
Conversation
This was referenced Jan 10, 2024
Contributor
|
Treating this as a fast-track feature. |
nex3
approved these changes
Jan 16, 2024
nex3
added a commit
that referenced
this pull request
Mar 27, 2024
Co-authored-by: Natalie Weizenbaum <nweiz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a performance enhancement that if the special js-api
Logger.silentis requested by the user, we can setCompileRequest.silentto completely bypass the unnecessary serialization, sending, and deserialization ofLogEvents, thus making the compilation more efficient in the case where lots of log messages are supposed to be suppressed.