Skip to content

[Shared Resources] Draft 1.3#3766

Merged
nex3 merged 3 commits intosass:mainfrom
oddbird:feature.shared-resources.draft-1.3
Dec 15, 2023
Merged

[Shared Resources] Draft 1.3#3766
nex3 merged 3 commits intosass:mainfrom
oddbird:feature.shared-resources.draft-1.3

Conversation

@jamesnw
Copy link
Contributor

@jamesnw jamesnw commented Dec 14, 2023

No description provided.

@jamesnw jamesnw requested a review from nex3 December 14, 2023 19:32
#### Compiler

An instance of the synchronous Compiler.
An instance of the synchronous Compiler. If the constructor is directly invoked
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"invoked" -> "constructed"

Shouldn't these also have private constructors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 3a4ca47

@jamesnw jamesnw requested a review from nex3 December 15, 2023 03:34
@nex3 nex3 merged commit 25d84af into sass:main Dec 15, 2023
nex3 pushed a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants