Skip to content

[Color 4] Draft 1.3 changes for Color spaces JS API#3721

Merged
nex3 merged 3 commits intosass:mainfrom
oddbird:color-spaces-js-changes-1.3
Oct 17, 2023
Merged

[Color 4] Draft 1.3 changes for Color spaces JS API#3721
nex3 merged 3 commits intosass:mainfrom
oddbird:color-spaces-js-changes-1.3

Conversation

@jgerigmeyer
Copy link
Contributor

@jgerigmeyer jgerigmeyer requested a review from nex3 October 16, 2023 19:11
Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not merging this yet because I think we'll also want to change SassColor.interpolate() to take a positional parameter.

@jgerigmeyer jgerigmeyer requested a review from nex3 October 17, 2023 20:16
@jgerigmeyer
Copy link
Contributor Author

jgerigmeyer commented Oct 17, 2023

@nex3 I moved color2 to a positional parameter, and also added the missing rec2020 color space. Ready for another round of review.

@nex3 nex3 merged commit 75ced5c into sass:main Oct 17, 2023
@jgerigmeyer jgerigmeyer deleted the color-spaces-js-changes-1.3 branch October 18, 2023 01:59
jgerigmeyer added a commit to oddbird/sass that referenced this pull request Oct 18, 2023
* main:
  [Color 4] Draft 1.3 changes for Color spaces JS API (sass#3721)
  Bump bufbuild/buf-setup-action from 1.26.1 to 1.27.0 (sass#3713)
  Bump tj-actions/changed-files from 39.2.0 to 39.2.2 (sass#3720)
jgerigmeyer added a commit to oddbird/sass that referenced this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants