Conversation
nex3
requested changes
Feb 24, 2023
Comment on lines
+5
to
+6
| * Missing channels and mixed numbers/percentages are not allowed in legacy | ||
| comma-separated `rgb`/`rgba` or `hsl`/`hsla` syntaxes. |
Contributor
There was a problem hiding this comment.
We already allow mixed numbers/percentages in this syntax, so we need to continue to do so for backwards compat even if CSS forbids it.
nex3
approved these changes
Mar 6, 2023
nex3
added a commit
to sass/sass-spec
that referenced
this pull request
Mar 21, 2023
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Mar 21, 2023
nex3
added a commit
to sass/sass-spec
that referenced
this pull request
Mar 23, 2023
Update specs for sass/sass#3497
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Mar 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rgba()is legacy so does not supportnone. Right? w3c/csswg-drafts#7900 / [css-color-5] Clarification of rgb() syntax w3c/csswg-drafts#8231