Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Remove the non-standard compact function#835

Merged
xzyfer merged 1 commit intosass:masterfrom
xzyfer:feat/remove-compact
Feb 16, 2015
Merged

Remove the non-standard compact function#835
xzyfer merged 1 commit intosass:masterfrom
xzyfer:feat/remove-compact

Conversation

@xzyfer
Copy link
Copy Markdown
Contributor

@xzyfer xzyfer commented Jan 12, 2015

This PR removes the non-standard compact function.

This PR exhibits the same behaviour as #834 and will be adjusted to match the final decision made there.

Fixes #585.

@xzyfer xzyfer added this to the 3.2 milestone Jan 12, 2015
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.11%) when pulling 3372964 on xzyfer:feat/remove-compact into 3a07c14 on sass:master.

@xzyfer
Copy link
Copy Markdown
Contributor Author

xzyfer commented Feb 15, 2015

Any objections to shipping this?

Please read the discussion in #834

@HamptonMakes
Copy link
Copy Markdown
Member

Hmm... makes me think maybe we should as Sass if they will add this feature.

But, remove it for now, as it's not covered in Sass.

@akhleung
Copy link
Copy Markdown

I believe variadic argument lists were supposed to make this function unnecessary.

xzyfer added a commit that referenced this pull request Feb 16, 2015
Remove the non-standard compact function
@xzyfer xzyfer merged commit 003d3dc into sass:master Feb 16, 2015
@xzyfer xzyfer self-assigned this Feb 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should libsass have a compact function?

5 participants