fix total test count over loops#65
Open
sarthakaggarwal97 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
96ac8d6 to
34645f3
Compare
34645f3 to
b5d58d4
Compare
|
Can you explain or show an example how the result looked before and after and why it was wrong? |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Owner
Author
|
@zuiderkwast my bad I accidently closed this PR. With the label present, the extra tests are running. I will take an SS and show in this PR how it works. Would need this run to be completed. |
5f9f38a to
97b914c
Compare
zuiderkwast
pushed a commit
to valkey-io/valkey
that referenced
this pull request
Feb 16, 2026
…3202) We made some changes to the workflow where the label was getting removed every time we ran it. This changes handles it, removes `pull_request_target` and doesn't re-trigger on adding another label. I tried it here: sarthakaggarwal97#65 The code is already merged in my unstable. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
dc95622 to
556180d
Compare
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
…alkey-io#3202) We made some changes to the workflow where the label was getting removed every time we ran it. This changes handles it, removes `pull_request_target` and doesn't re-trigger on adding another label. I tried it here: sarthakaggarwal97#65 The code is already merged in my unstable. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Mar 5, 2026
…alkey-io#3202) We made some changes to the workflow where the label was getting removed every time we ran it. This changes handles it, removes `pull_request_target` and doesn't re-trigger on adding another label. I tried it here: sarthakaggarwal97#65 The code is already merged in my unstable. Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
21e804f to
fb655db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.