evict client only when limit is breached#61
Closed
sarthakaggarwal97 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
madolson
pushed a commit
to valkey-io/valkey
that referenced
this pull request
Jan 21, 2026
…table (#3092) Thanks madolson for pointing out the issue with #2907. Whenever we were using the label, it was picking up the head of the unstable instead of the PR. The reason was that we changed the target to `pull_request_target`. We had to do that since we wanted to remove the label after the run is completed. With this change, it correctly picks up the commit hash of the PR and checks it out. To test this, I merged the changes in my forked repository's [unstable](unstable...sarthakaggarwal97:valkey:unstable), created a dummy [PR](sarthakaggarwal97#61), and was able to verify that the commit of the PR is being checked out in the [action](https://github.com/sarthakaggarwal97/valkey/actions/runs/21229598167/job/61084986422?pr=61#step:3:81). Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
arshidkv12
pushed a commit
to arshidkv12/valkey
that referenced
this pull request
Jan 23, 2026
…table (valkey-io#3092) Thanks madolson for pointing out the issue with valkey-io#2907. Whenever we were using the label, it was picking up the head of the unstable instead of the PR. The reason was that we changed the target to `pull_request_target`. We had to do that since we wanted to remove the label after the run is completed. With this change, it correctly picks up the commit hash of the PR and checks it out. To test this, I merged the changes in my forked repository's [unstable](valkey-io/valkey@unstable...sarthakaggarwal97:valkey:unstable), created a dummy [PR](sarthakaggarwal97#61), and was able to verify that the commit of the PR is being checked out in the [action](https://github.com/sarthakaggarwal97/valkey/actions/runs/21229598167/job/61084986422?pr=61#step:3:81). Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: arshidkv12 <arshidkv12@gmail.com>
0075053 to
928e912
Compare
ed90dd4 to
fb7b3fb
Compare
fb7b3fb to
32be217
Compare
|
🤖 AI Review The PR changes the client eviction condition from Key findings:
The code change itself is minimal, focused, and correct. Add a test and it's ready to merge. |
dc95622 to
556180d
Compare
harrylin98
pushed a commit
to harrylin98/valkey_forked
that referenced
this pull request
Feb 19, 2026
…table (valkey-io#3092) Thanks madolson for pointing out the issue with valkey-io#2907. Whenever we were using the label, it was picking up the head of the unstable instead of the PR. The reason was that we changed the target to `pull_request_target`. We had to do that since we wanted to remove the label after the run is completed. With this change, it correctly picks up the commit hash of the PR and checks it out. To test this, I merged the changes in my forked repository's [unstable](valkey-io/valkey@unstable...sarthakaggarwal97:valkey:unstable), created a dummy [PR](sarthakaggarwal97#61), and was able to verify that the commit of the PR is being checked out in the [action](https://github.com/sarthakaggarwal97/valkey/actions/runs/21229598167/job/61084986422?pr=61#step:3:81). Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
hpatro
pushed a commit
to hpatro/valkey
that referenced
this pull request
Mar 5, 2026
…table (valkey-io#3092) Thanks madolson for pointing out the issue with valkey-io#2907. Whenever we were using the label, it was picking up the head of the unstable instead of the PR. The reason was that we changed the target to `pull_request_target`. We had to do that since we wanted to remove the label after the run is completed. With this change, it correctly picks up the commit hash of the PR and checks it out. To test this, I merged the changes in my forked repository's [unstable](valkey-io/valkey@unstable...sarthakaggarwal97:valkey:unstable), created a dummy [PR](sarthakaggarwal97#61), and was able to verify that the commit of the PR is being checked out in the [action](https://github.com/sarthakaggarwal97/valkey/actions/runs/21229598167/job/61084986422?pr=61#step:3:81). Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: Harkrishn Patro <bunty.hari@gmail.com>
21e804f to
fb655db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.