Skip to content

Test PR to see PR template and bot comments in action#2

Open
saraedum wants to merge 3 commits intodevelopfrom
deleteme
Open

Test PR to see PR template and bot comments in action#2
saraedum wants to merge 3 commits intodevelopfrom
deleteme

Conversation

@saraedum
Copy link
Copy Markdown
Owner

@saraedum saraedum commented Apr 4, 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2024

Documentation preview for this PR (built with commit 0bc1029; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 11, 2024
sagemathgh-37740: Disable most documentation notifications on GitHub
    
Previously, the documentation comment on GitHub would be removed and
then recreated whenever there is a change to a PR which creates
notification emails and to some feels like it's polluting their GitHub
inbox.

Here, we change this behavior so that only the initial build of the
documentation causes such a notification. Further updates to the
documentation do update the links in the comment but do not trigger a
notification.

This is meant as an alternative to sagemath#37387. See sagemath#37739 for futher ideas
about a smarter behavior here.

An actual preview of the result can be seen here:
saraedum#2

Note that the links on that PR do not work because my fork does not have
netlify credentials configured.

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes; this is fairly hard to
test automatically. I'll test this manually if there is interest in
merging this.
- [x] I have updated the documentation accordingly; kind of, I updated
the PR checklist.
    
URL: sagemath#37740
Reported by: Julian Rüth
Reviewer(s): Dima Pasechnik, Julian Rüth, Kwankyu Lee
mkoeppe pushed a commit that referenced this pull request Aug 3, 2024
Remove excessive blank lines around INPUT, OUTPUT, EXAMPLES, and before
docstring ending """. (#2)
mkoeppe pushed a commit that referenced this pull request Sep 4, 2024
mkoeppe pushed a commit that referenced this pull request Sep 4, 2024
* Add some `except`s

For C-return-type functions that raise exceptions (and their heirs).

* Use `except?` for `_rank`
saraedum pushed a commit that referenced this pull request Apr 22, 2025
bump up external meson's minimal version for scipy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant