Limit samtools sort memory in tests#2226
Merged
Merged
Conversation
Invocations of `samtools sort` in test/test.pl only process small inputs, so the use the option `-m 10M` to keep the sort buffer small. This was missing from some of the minimiser sort tests, leading to them failing on constrained systems that are reluctant to over commit memory.
daviesrob
added a commit
to daviesrob/samtools
that referenced
this pull request
Jul 10, 2025
Invocations of `samtools sort` in test/test.pl only process small inputs, so the use the option `-m 10M` to keep the sort buffer small. This was missing from some of the minimiser sort tests, leading to them failing on constrained systems that are reluctant to over commit memory.
daviesrob
added a commit
to daviesrob/samtools
that referenced
this pull request
Mar 18, 2026
Invocations of `samtools sort` in test/test.pl only process small inputs, so the use the option `-m 10M` to keep the sort buffer small. This was missing from some of the minimiser sort tests, leading to them failing on constrained systems that are reluctant to over commit memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Invocations of
samtools sortin test/test.pl only process small inputs, so the use the option-m 10Mto keep the sort buffer small. This was missing from some of the minimiser sort tests, leading to them failing on constrained systems that are reluctant to over commit memory.