Fix broken tests due to msys2 changes.#2196
Merged
Merged
Conversation
Due to changes in how msys2 perl reported the identity of the OS it was built for, our tests were failing to adapt to the Windows style file locations. Background: https://www.msys2.org/news/#2025-02-14-moving-msys2-closer-to-cygwin Msys2 PR: msys2/MSYS2-packages#5177
8227d47 to
588efe9
Compare
daviesrob
pushed a commit
to daviesrob/samtools
that referenced
this pull request
Mar 18, 2026
Due to changes in how msys2 perl reported the identity of the OS it was built for, our tests were failing to adapt to the Windows style file locations. Background: https://www.msys2.org/news/#2025-02-14-moving-msys2-closer-to-cygwin Msys2 PR: msys2/MSYS2-packages#5177 (cherry picked from commit 74ae962)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to changes in how msys2 perl reported the identity of the OS it was built for, our tests were failing to adapt to the Windows style file locations and line endings.
Background:
https://www.msys2.org/news/#2025-02-14-moving-msys2-closer-to-cygwin
Msys2 PR:
msys2/MSYS2-packages#5177