Improve htslib#PRnum support for Cirrus-CI and GitHub Actions#2115
Merged
Conversation
Cirrus-CI stopped knowing the author's branch name at some point and instead reported the branch name in the repository we're making a PR against (pull/num). So instead we added the ability to specify htslib#NUM to the first line of a samtools PR to enable joint samtools/htslib PRs to work. This wasn't particularly robust and had problems when not working as a PR (ie in the authors own repositories). It was also completely absent from GitHub Actions. Note there's no way of knowing the PR number for GitHub actions short of doing a git log, and it only has one commit in the log which is a merge commit. I changed it to use pull/NUM/head instead of pull/NUM/merge, but possibly it would be better done with "fetch-depth: 2" instead. It's no big deal though as we check the mergability elsewhere.
jkbonfield
added a commit
to jkbonfield/bcftools
that referenced
this pull request
Sep 26, 2024
jkbonfield
added a commit
to jkbonfield/bcftools
that referenced
this pull request
Sep 26, 2024
jkbonfield
added a commit
to jkbonfield/bcftools
that referenced
this pull request
Sep 26, 2024
jkbonfield
added a commit
to jkbonfield/bcftools
that referenced
this pull request
Sep 26, 2024
daviesrob
pushed a commit
to daviesrob/bcftools
that referenced
this pull request
Oct 21, 2024
daviesrob
pushed a commit
to daviesrob/bcftools
that referenced
this pull request
Mar 18, 2026
Analogous to samtools/samtools#2115 (cherry picked from commit a781f5b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cirrus-CI stopped knowing the author's branch name at some point and instead reported the branch name in the repository we're making a PR against (pull/num). So instead we added the ability to specify htslib#NUM to the first line of a samtools PR to enable joint samtools/htslib PRs to work. This wasn't particularly robust and had problems when not working as a PR (ie in the authors own repositories).
It was also completely absent from GitHub Actions. Note there's no way of knowing the PR number for GitHub actions short of doing a git log, and it only has one commit in the log which is a merge commit. I changed it to use pull/NUM/head instead of pull/NUM/merge, but possibly it would be better done with "fetch-depth: 2" instead. It's no big deal though as we check the mergability elsewhere.