Add a CRAM file size regression test#1969
Merged
Merged
Conversation
This mainly tests htslib, but it doesn't have a good large general purpose CRAM file for validation. We don't really have a large enough one here either, but this is sufficient. We could create our own artificial one, but the current test spots the problem in samtools#1968 so it's an easy starting point. Are there zlib, bzip2, or lzma implementations which break this? I tested zlib and libdeflate, and our check is 2% over that so this is a reasonable buffer. If it breaks, we can amend the testing.
daviesrob
added a commit
to daviesrob/samtools
that referenced
this pull request
Apr 12, 2024
whitwham
pushed a commit
that referenced
this pull request
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mainly tests htslib, but it doesn't have a good large general purpose CRAM file for validation. We don't really have a large enough one here either, but this is sufficient.
We could create our own artificial one, but the current test spots the problem in #1968 so it's an easy starting point. Are there zlib, bzip2, or lzma implementations which break this? I tested zlib and libdeflate, and our check is 2% over that so this is a reasonable buffer.
If it breaks, we can amend the testing.