Parsing scientific notation as integers#171
Merged
Merged
Conversation
for example 20:30000000-32000000 can be now given also as 20:3e7-3.2e7. Replaced atoi parameter parsing with strtol to recognised user errors.
Add a function encapsulating parsing either integer or scientific notation and returning int. This allows integer items such as regions to be given in scientific notation if desired, while ensuring that when given as integers they are unequivocally parsed accurately as integers.
b71f89c to
80f5bc5
Compare
Parse digits by hand in hts_parse_decimal(), allowing integer parsing of integer or scientific notation possibly with commas (before the decimal point), and allowing possible future expansion to "3Mbp" and the like. Add doxygen-style documentation, noting that warnings will be produced for invalid input. Rewrite hts_parse_reg() to take advantage of hts_parse_decimal()'s comma abilities and validation. Return NULL (instead of suggesting the sequence name is the whole region string) when the region cannot be parsed. (Changing the "*beg > *end" test to ">=" fixes the off-by-1 aspect of samtools/samtools#353; returning NULL provides the opportunity to improve the error message.)
80f5bc5 to
6b40323
Compare
jmarshall
added a commit
that referenced
this pull request
Mar 30, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This suggested pull request adds to the previous scientific notation functionality (772ba54), adding a utility function that uses strtol() when it can (so faithful accuracy is clear and obvious) or strtod() if needed (because scientific notation has been used).