Bug fix: handling of CRLF line terminators in sam_parse_worker()#1149
Merged
daviesrob merged 4 commits intosamtools:developfrom Oct 7, 2020
Merged
Bug fix: handling of CRLF line terminators in sam_parse_worker()#1149daviesrob merged 4 commits intosamtools:developfrom
daviesrob merged 4 commits intosamtools:developfrom
Conversation
Member
|
Looks good, though I will have to go through the tests more carefully. |
Member
|
Added a test for a CRLF sam file. |
Member
|
Thanks for the fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #1148
Also adds a few test cases for kstring which were written while troubleshooting.