Skip to content

CRLF line termination not handled properly in sam_parse_worker #1148

@anderskaplan

Description

@anderskaplan

To reproduce: unix2dos test/index.sam, then run the test suite.

Actual: The test test_index fails, but only in the multi-threaded case. The single-threaded case passes.
This is because the line parser in sam_parse_worker does not handle CRLF line endings properly. The CR is passed on to sam_parse1 where it is included in the aux field data. The resulting BAM differs from the reference.

Expected: The test suite should pass regardless of line endings.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions