Skip to content

Conversation

@NathanBaulch
Copy link
Contributor

I'm personally a fan of the extra gofumpt rules. Feel free to close this PR if you think they're overly strict.

@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

❌ Patch coverage is 89.70588% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.51%. Comparing base (1df48c4) to head (83f6244).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
tuples.go 56.25% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #690   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files          18       18           
  Lines        3430     3430           
=======================================
  Hits         3242     3242           
  Misses        174      174           
  Partials       14       14           
Flag Coverage Δ
unittests 94.51% <89.70%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samber
Copy link
Owner

samber commented Sep 26, 2025

I prefer explicit parameters, but the Go community has decided to group parameters ;)

@samber samber merged commit f5aac81 into samber:master Sep 26, 2025
10 of 11 checks passed
@NathanBaulch NathanBaulch deleted the gofumptextra branch September 26, 2025 12:20
NathanBaulch added a commit to NathanBaulch/lo that referenced this pull request Sep 30, 2025
Co-authored-by: Samuel Berthe <dev@samuel-berthe.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants