perf: avoid Keyify twice in Trim #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #689 +/- ##
==========================================
+ Coverage 94.49% 94.51% +0.02%
==========================================
Files 18 18
Lines 3416 3430 +14
==========================================
+ Hits 3228 3242 +14
Misses 174 174
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Actually, thinking about this more... Chaining |
NathanBaulch
added a commit
to NathanBaulch/lo
that referenced
this pull request
Sep 30, 2025
* perf: avoid Keyify twice in Trim * pref: avoid two slice allocations in Trim
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chaining
TrimLeftandTrimRightmeans the input collection will be unnecessarily "Keyified" twice.Speaking of trim helpers, I was surprised to see that
TrimPrefixtrims all instances of the leading slice, not just the first. This is different from the stdlibstrings.TrimPrefixand should probably be documented. Same with the suffix version.