lint: fix CI warnings and avoid named return parameters #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #682 +/- ##
=======================================
Coverage 94.31% 94.32%
=======================================
Files 18 18
Lines 3362 3367 +5
=======================================
+ Hits 3171 3176 +5
Misses 176 176
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4abf851 to
75a91b3
Compare
Contributor
Author
|
This also restores golangci-lint to latest version, as discussed in #671. |
75a91b3 to
161b837
Compare
Contributor
Author
|
#666 introduced quite a few linting issues. Shouldn't all PR checks be passing before a PR is merged? |
Owner
|
Thanks for your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest golangci-lint version now warns against naked returns. This PR fixes those and also removes unnecessary named return parameters in a few places. IMO named parameters should only be used on functions that use
recover()and functions that have > 2 non-obvious return values.